fix merge with upstream kernel attribute refactor #18868
Conversation
Signed-off-by: Sarnie, Nick <[email protected]>
|
Hi @intel/dpcpp-cfe-reviewers @premanandrao @Fznamznon , can someone take a look at this? It's not complicated but it's not really trivial either. Thanks! |
Fznamznon
left a comment
Fznamznon
left a comment
There was a problem hiding this comment.
Oh, I'm slightly worried about this, because we use sycl_kernel attribute in the downstream and we managed to upstream it at some point, but the clang upstreaming team last year decided that we should invent a new attribute for these purposes called sycl_kernel_entry point and we will need to clean this mess at some point, but that is not your problem atm. cc @tahonermann
| // so handle that case manually. | ||
| return A.getAttributeSpellingListIndex() == Keyword_kernel || | ||
| A.getAttrName()->getName() == "kernel"; | ||
| (A.getAttrName() && A.getAttrName()->getName() == "kernel"); |
There was a problem hiding this comment.
How is this change specific to this downstream?
There was a problem hiding this comment.
Sorry it's not but the issue was only exposed downstream, I'll fix it upstream.
There was a problem hiding this comment.
|
btw about |
Signed-off-by: Sarnie, Nick <[email protected]>
|
thanks mariya! |
2 participants
Fix merge with my upstream change to refactor the device kernel attribute here.